jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.
https://jupyter-server.readthedocs.io
BSD 3-Clause "New" or "Revised" License
484 stars 295 forks source link

log extension import time at debug level unless it's actually slow #1375

Closed minrk closed 10 months ago

minrk commented 10 months ago

avoids unnecessary noise most of the time, while still reporting when things are slow enough to cause a problem.

Zsailer commented 10 months ago

Thanks, @minrk! Love this.

yuvipanda commented 9 months ago

The pr title is missing a “don’t” i think.

minrk commented 9 months ago

I think the PR title is accurate. It's at info level if it's slow, debug if it's not.

yuvipanda commented 9 months ago

Aaaah, sorry I somehow didn't parse the 'at debug level'