Ignore zero-length page_config.json, restore previous behavior of crashing for invalid JSON

jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.

https://jupyter-server.readthedocs.io

BSD 3-Clause "New" or "Revised" License

465 stars 279 forks source link

Ignore zero-length page_config.json, restore previous behavior of crashing for invalid JSON #1405

Closed holzman closed 3 months ago

holzman commented 3 months ago

Hi,

Thanks for merging my earlier patch!

Please see the comments here from @manics and @krassowski here (https://github.com/jupyterlab/jupyterlab_server/pull/444) on a similar patch for jupyterlab_server. There are reasonable arguments to be made for continuing to crash on invalid JSON.

I've prepared this PR which preserves the previous behavior and only ignores the page_config.json file if it's zero-length.