jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.
https://jupyter-server.readthedocs.io
BSD 3-Clause "New" or "Revised" License
465 stars 279 forks source link

Do not include token in dashboard link, when available #1406

Closed minrk closed 3 months ago

minrk commented 3 months ago

this was added to make transferrable login more convenient long ago, but persisting hashed passwords are the way to go these days, and this isn't the right thing to do in e.g. jupyterhub

ref: https://discourse.jupyter.org/t/is-it-possible-to-avoid-exposing-token-in-get-parameter-in-jupyterhub/24367

This is not a vulnerability, just an improvement in where we pass tokens and when.