jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.
https://jupyter-server.readthedocs.io
BSD 3-Clause "New" or "Revised" License
465 stars 279 forks source link

Fix outdated security documentation #1428

Open colinpalmer opened 4 weeks ago

colinpalmer commented 4 weeks ago

The security documentation at https://jupyter-server.readthedocs.io/en/latest/operators/security.html is out of date.

It has a section that describes an additional one-time token used for browser launch, but this behaviour was replaced by a redirect file a few years ago in https://github.com/jupyter/notebook/pull/4260.

Please could the docs be updated to describe the current implementation? Thanks!

welcome[bot] commented 4 weeks ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

krassowski commented 1 week ago

Good point! Would you like to open a PR?

colinpalmer commented 1 week ago

I can do, yes. I'm busy just now but maybe in a couple of weeks?