jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.
https://jupyter-server.readthedocs.io
BSD 3-Clause "New" or "Revised" License
465 stars 279 forks source link

extensions: render default templates with default static_url #1435

Open minrk opened 5 days ago

minrk commented 5 days ago

avoids rendering errors or incorrect URLs for error pages, which must use the base static_url function

closes #1434

A probably cleaner approach would be to attach static_url to jinja environment globals instead of a method on the Handler, but the compatibility implications of switching to that are more complicated than I felt comfortable tackling.