jupyter-server / jupyter_server_fileid

An extension that maintains file IDs for documents in a running Jupyter Server
https://jupyter-server-fileid.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

remove unused REST API #36

Closed dlqqq closed 2 years ago

dlqqq commented 2 years ago

cc @davidbrochart

Per internal discussion with RTC team, there are currently no known use-cases for the REST API at this time, and we are thus removing it from the codebase.

codecov-commenter commented 2 years ago

Codecov Report

Base: 81.43% // Head: 84.20% // Increases project coverage by +2.76% :tada:

Coverage data is based on head (631af4a) compared to base (71c90c6). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== + Coverage 81.43% 84.20% +2.76% ========================================== Files 5 4 -1 Lines 544 500 -44 Branches 71 67 -4 ========================================== - Hits 443 421 -22 + Misses 79 57 -22 Partials 22 22 ``` | [Impacted Files](https://codecov.io/gh/jupyter-server/jupyter_server_fileid/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jupyter-server) | Coverage Δ | | |---|---|---| | [jupyter\_server\_fileid/extension.py](https://codecov.io/gh/jupyter-server/jupyter_server_fileid/pull/36/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jupyter-server#diff-anVweXRlcl9zZXJ2ZXJfZmlsZWlkL2V4dGVuc2lvbi5weQ==) | `34.48% <ø> (-3.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jupyter-server). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jupyter-server)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.