search

jupyter-server / jupyter_server_fileid

An extension that maintains file IDs for documents in a running Jupyter Server
https://jupyter-server-fileid.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Update check-jsonschema usage to latest style #50

Closed sirosen closed 1 year ago

sirosen commented 1 year ago

I'm trying to improve the common/normative home of this hook by finding repos which appear active and informing maintainers of the newer home. There's no harm in using the old URL, but I don't know that GitHub will serve the redirect indefinitely (especially if I take some accidentally destructive action, e.g. forking the repo back to my account).

This also looks to be part of the same org which originated https://github.com/python-jsonschema/check-jsonschema/issues/183 , so that and the related jupyter-server changes may be relevant here.

Cheers!

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

codecov[bot] commented 1 year ago

Codecov Report

Base: 85.74% // Head: 85.74% // No change to project coverage :thumbsup:

Coverage data is based on head (a03a08c) compared to base (50dec2e). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #50 +/- ## ======================================= Coverage 85.74% 85.74% ======================================= Files 4 4 Lines 519 519 Branches 68 68 ======================================= Hits 445 445 Misses 52 52 Partials 22 22 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jupyter-server). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jupyter-server)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: