Add source to dist for sourcemaps

jupyter-server / jupyter_ydoc

Jupyter document structures for collaborative editing using Yjs/pycrdt

https://jupyter-ydoc.readthedocs.io

BSD 3-Clause "New" or "Revised" License

27 stars 17 forks source link

Add source to dist for sourcemaps #182

Closed vidartf closed 10 months ago

vidartf commented 10 months ago

We currently generate and distribute source maps, but not the source that the sourcemaps point to. As exemplified by this warning:

WARNING in ../../node_modules/@jupyter/ydoc/lib/ytext.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '<root>\node_modules\@jupyter\ydoc\src\ytext.ts' file: Error: ENOENT: no such file or directory, open '<root>\node_modules\@jupyter\ydoc\src\ytext.ts'

This change will include the source files in the package dist.

welcome[bot] commented 10 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

vidartf commented 10 months ago

c.f. https://github.com/jupyterlab/jupyterlab/pull/14028

welcome[bot] commented 10 months ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: