Change notebook code cell stream output schema

jupyter-server / jupyter_ydoc

Jupyter document structures for collaborative editing using Yjs/pycrdt

https://jupyter-ydoc.readthedocs.io

BSD 3-Clause "New" or "Revised" License

25 stars 16 forks source link

Closed davidbrochart closed 1 month ago

davidbrochart commented 7 months ago

Closes #200.

davidbrochart commented 1 month ago

Do we agree on merging this PR?

Zsailer commented 1 month ago

Yeah, I think this is the right way to handle stream outputs. Great work, @davidbrochart!

The code looks good. Would you mind adding unit tests to cover this case? Or open an issue to add unit tests in a follow-up PR.

davidbrochart commented 1 month ago

Yes, I'll add tests in this PR.

Zsailer commented 1 month ago

Thanks, @davidbrochart! LGTM!