Cannot make a release

[davidbrochart]

Description

I created a draft release but I cannot publish it. There is an error with npm whoami, maybe I don't have the rights?

cc @Zsailer @fcollonval @krassowski @jtpio

[jtpio]

@davidbrochart I bumped your rights to "Admin". They were set to "Write" reviously, and with the "mixed roles" warning.

Would you be able to try again?

[jtpio]

Also it looks like the draft release was created with @fcollonval account: https://github.com/jupyter-server/jupyter_ydoc/releases/tag/untagged-0497b4902adcd4680709

Maybe we should streamline the process for this repo and use the GitHub app for the jupyter-server organization, like for the other repos under this org.

[davidbrochart]

Would you be able to try again?

Thanks @jtpio, but it doesn't seem to be enough, see here.

Maybe we should streamline the process for this repo and use the GitHub app for the jupyter-server organization, like for the other repos under this org.

Probably, but I'm not sure I have the rights for this either?

[jtpio]

OK it looks like I should be able to add the proper credentials from the Jupyter password to this repo.

I opened https://github.com/jupyter-server/jupyter_ydoc/pull/244 to update the workflows.

[jtpio]

I just set the two variables for the release environment on this repo:

And invited jupyter-server-release-bot to join the jupyter org on npm.

And also just added the trusted publisher to PyPI:

[jtpio]

@davidbrochart would you like to try running the workflows again? I deleted the previous draft release.

[davidbrochart]

Thanks, it failed again but with a different error:

***github.com/jupyter-server/jupyter_ydoc.git
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: Changes must be made through a pull request.
To https://github.com/jupyter-server/jupyter_ydoc.git
 * [new tag]         @jupyter/ydoc@3.0.0-a1 -> @jupyter/ydoc@3.0.0-a1
 * [new tag]         v3.0.0a1 -> v3.0.0a1
 ! [remote rejected] HEAD -> main (protected branch hook declined)
error: failed to push some refs to 'https://github.com/jupyter-server/jupyter_ydoc.git'

[jtpio]

Looks like it's because there is already a tag on the repo?

Maybe worth trying again by deleting the draft release and the tags, and running the workflows again?

[davidbrochart]

That's what I did, but I'll try again.

[davidbrochart]

Same result, maybe this commit should be reverted?

[jtpio]

Ah yes, let's try to revert that commit and publish 3.0.0a0 (not 3.0.0a1)

[davidbrochart]

Unfortunately it still doesn't work (see here).

[jtpio]

OK it might be related to some kind of branch protection rule, let me check.

[jtpio]

I just added the same ruleset as for the Jupyter Server repository: https://github.com/jupyter-server/jupyter_server

And restarted the workflow, let's see if that fixes it.

[jtpio]

OK looking good this time: https://github.com/jupyter-server/jupyter_ydoc/releases/tag/v3.0.0a0

Closing as fixed!

[davidbrochart]

Thanks so much @jtpio.