jupyter-server / pycrdt-websocket

WebSocket Connector for pycrdt
https://jupyter-server.github.io/pycrdt-websocket
MIT License
14 stars 10 forks source link

change yroom class attribute to instance attribute and stop ystore in stop method #39

Open jzhang20133 opened 6 months ago

jzhang20133 commented 6 months ago

Previously, some same named instance attributes are created or defined outside of initializer and YRoom does not need class attributes hence we change yroom class attributes to instance attribute just to improve readability. In this PR we also stop ystore in yroom.stop() method.

Added a unit test to ystore stop inside yroom.stop() and unit test need https://github.com/jupyter-server/pycrdt-websocket/pull/42 to be merged. Need to wait until https://github.com/jupyter-server/pycrdt-websocket/pull/42 is merged and then rebased.