search

jupyter-server / pycrdt-websocket

WebSocket Connector for pycrdt
https://jupyter-server.github.io/pycrdt-websocket
MIT License
14 stars 10 forks source link

Start the server awareness #78

Closed brichet closed 1 month ago

brichet commented 1 month ago

This PR start the server awareness periodic update.

It follows https://github.com/jupyter-server/pycrdt/pull/178.

davidbrochart commented 1 month ago

Let me know if you need help with this (I see tests are failing).

brichet commented 1 month ago

Yes, I took a look at the tests, it seems that test_yroom_restart never ends.

The tests pass if we remove the error if the awareness is already started. This probably means that the awareness is not properly stopped, but I don't know how to fix it. And I'm not sure if we need to raise in this case.

brichet commented 1 month ago

Thanks @davidbrochart