jupyter-server / pycrdt

CRDTs based on Yrs.
https://jupyter-server.github.io/pycrdt
MIT License
42 stars 10 forks source link

New strategy for document validation #65

Open davidbrochart opened 8 months ago

davidbrochart commented 8 months ago

Problem

The current method for validating documents is having a copy of the document, applying changes to it, and if it's still a valid document, applying the changes to the original document. It's expensive because documents and operations are duplicated.

Proposed Solution

If updates are stored e.g. in a YStore, a better solution could be to always apply changes to the original document, and if it fails validation, create a new document from the stored updates (and not store the last update).

welcome[bot] commented 8 months ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: