Meeting Notes 2022 - Githubissues

jupyter-server / team-compass

A repository for team discussion, syncing, and meeting notes.

https://jupyter-server-team-compass.readthedocs.io

BSD 3-Clause "New" or "Revised" License

13 stars 8 forks source link

Meeting Notes 2022 #15

Closed Zsailer closed 1 year ago

Zsailer commented 2 years ago

Hello everyone,

Welcome to the Jupyter Server Team!

You can find us in our Gitter chat room or visit us at our weekly meetings!

We meet on Thursdays at 8:00am, Pacific Standard Time on Jupyter's Zoom Channel. You can add yourself to the weekly agenda here. Everyone is welcome!

Let's avoid using this thread for discussion. If you'd like to discuss something in the minutes, open a separate issue and reference this thread.

Meeting Notes

kevin-bates commented 1 year ago

October 27th, 2022

Name	affiliation	username
Zach Sailer	Apple	@Zsailer
Vidar T Fauske	JP Morgan Chase	@vidartf
Steve Silvester	MongoDB	@blink1073
Brian Granger	AWS	@ellisonbg
Kevin Bates	IBM	@kevin-bates
Andrii Ieroshenko	AWS	@andrii-i
A. T. Darian	QuantStack	@afshin
Kiersten Stokes	IBM	@kiersten-stokes

Agenda

Zach
- Jupyter Executive Council (self) nominations. If you're interested, please fill out the form.
Brian
- Public API of IdentityProvider, how to extend?
  - It's not clear which methods in the Identity provider are necessary for working with the rest of Jupyter Server.
  - We should define an Abstract Base Class to set this interface in stone to avoid future breaking changes.
- Packaging and defaults for file id service.
Steve
- Asyncio refactor - managed to keep backward compat with the pytest_plugin. Found a race condition in client. Client 8 will have a slight change to Provisioner where the provisioner will be in charge of handling the connection file/info.
  - Make the async managers the default, and have the sync managers subclass those and be deprecated? This would allow the default trait class to be the async one.
- Move to support Python 3.8 - 3.11 in all new minor versions?

kevin-bates commented 1 year ago

November 3rd, 2022

Name	affiliation	username
Steve Silvester	MongoDB	@blink1073
Kevin Bates	IBM	@kevin-bates
Piyush Jain	AWS	@3coins
Kiersten Stokes	IBM	@kiersten-stokes
Andrii Ieroshenko	AWS	@andrii-i
Zach Sailer	Apple	@Zsailer
Frederic Collonval	QuantStack	@fcollonval
Rahul Goyal	AWS	@rahul26goyal
Vidar T Fauske	JP Morgan Chase	@vidartf
A. T. Darian	QuantStack	@afshin

Agenda

Frederic
- Binder and Jupyter Server 2 not working by default https://github.com/jupyter-server/jupyter_server/issues/1038
  - JUPYTERHUB_SINGLEUSER_APP env variable
  - [Zach] Open issue on Binder
- Move NPM package @jupyterlab/shared-models into jupyter-ydoc
  The goal is to get a single repo for defining/maintaining the Y schema of Jupyter document in Python and Javascript. Otherwise the risk of divergence is high (as proven by the initial jupyter-ydoc implementation).
- REST API and multi-users server
  Should the endpoint config be isolated per user? Or how to make it isolated optionally? https://github.com/jupyter-server/jupyter_server/issues/122
  https://github.com/jupyter-server/jupyter_server/pull/391
  The way around it for now is to use the authorization feature.
Steve
Kevin
- Enterprise Gateway 3.0 released :tada:
  - 3.0.1 will be out soon :smile: (need to cap server < 2)
- Remote Provisioners project is progressing
Zach
- Message Broker API: https://github.com/jupyter-server/jupyter_server/pull/1047

kevin-bates commented 1 year ago

November 10th, 2022

Name	affiliation	username
Steve Silvester	MongoDB	@blink1073
Kevin Bates	IBM	@kevin-bates
Zach Sailer	Apple	@Zsailer
Luciano Resende	Apple	@lresende
AT Darian	QuantStack	@afshin
Kiersten Stokes	IBM	@kiersten-stokes
Andrii Ieroshenko	AWS	@andrii-i
Piyush Jain	AWS	@3coins
Frederic Collonval	QuantStack	@fcollonval

Agenda

Steve
- Jupyter Core 5.0 released. We're now using the platform dirs in our test suite.
- One more PR for Jupyter Client 8
- Add authorization to AuthenticatedFileHandler
- Writing API errors to console
  - Discussion during the meeting: will this expose any security vulnerabilities? i.e. is there anything in the traceback that shouldn't be exposed on the console.
  - Previously, we caused a security issue by printing the access token to the console, so we're a little cautious here.
Kevin
- Should we inject a SQLAlchemy layer per this issue or wait and do this in jupyverse?
  - Kevin is planning to open an issue to discuss further (see Issue 1063)
  - Can we build a "Jupyter Server Database API" that's abstract enough to work with both jupyter_server and jupyverse?
  - Can we have an object store as well (e.g. Yjs/Ypy)?
Darian
- EventManager front-end: subscribing to the event bus emissions
  - JupyterLab PR (for JupyterLab 3.6) — quick show & tell
  - Lumino Stream that fell out of ⬆️ — for JupyterLab 4.0
Vidar
- preferred_dir PR: Needed to drop validation of preferred_dir due to async/sync.
Frederic
- 🤔⁇🧐❔🤨❓ (unable to join maybe toward the end of the meeting)
- Question about the responsibility of the ContentManager.
  I saw that the event emission is done within the contents managers like for get. Would it makes sense to do that in the handler to remove the event emission responsibility from the content manager (that may be custom)? The point was discussed and the decision was to place it in the manager because the manager may want to extend/add events (maybe more true for the kernel manager).
  To ease migration to v2 it may be interested to move the event emission to a base class or hooks that developer can use when migrating.
  We could also provide tests re-usable by developer to entire the managers contract.
  An alternative is to define event at the REST API level to be more reliable that emission by uncontrolled managers.

kevin-bates commented 1 year ago

November 17th, 2022

Name	affiliation	username
Zach Sailer	Apple	@Zsailer
Kevin Bates	IBM	@kevin-bates
Andrii Iersohenko	AWS	@andrii-i
Kiersten Stokes	IBM	@kiersten-stokes
Rahul Goyal	AWS	@rahul26goyal
Afshin T. Darian	QuantStack	@afshin
David Brochart	QuantStack	@davidbrochart

Agenda

Zach
- Did everyone see the email? Vote for EC by December 4th.
- Holiday season
  - Thanksgiving Holiday in the US. No Jupyter Server or Contributing Hour meeting next week (11/24)?
  - Christmas/New Years Holiday. No Jupyter Server + Contributing Hour meetings on December 12/29?
- I'll be going out on parent leave 12/22-2/3
- Discussed Websocket connection abstraction layer
  - https://github.com/jupyter-server/jupyter_server/pull/1047
  - One more unit test to fix; please review when folks have time.
  - Defines an ABC for connecting kernel websockets to their ZMQ sockets
  - Allows easy overriding of the websocket API. Decouples the business logic from the server framework choice (e.g. tornado, fastapi, etc.)
  - Might be helpful for transitioning folks to jupyverse in the future.
Kevin
- Move jupyter/nb2kg to jupyter_server and archive repo
  - Steve suggested to archive in place for future discovery (makes sense)
  - Kevin will open an issue in NG2KG referencing the team compass issue and call for a jupyter-server-council "vote" on the team-compass issue.
Steve
- While improving test coverage, noticed that the FilesHandler class is unused and untested, should we deprecate it in 2.0?
- Revive pytest-jupyter? https://github.com/jupyter-server/team-compass/issues/41
Darian
- Question re: events schemas
  - How do we check if the events API exists? e.g. JupyterLab 3.6.1 can use Jupyter Server 1.0 and 2.0.

kevin-bates commented 1 year ago

December 1st, 2022

Name	affiliation	username
Kevin Bates	IBM	@kevin-bates
Zach Sailer	Apple	@Zsailer
Andrii Ieroshenko	AWS	@andrii-i
Frederic Collonval	QuantStack	@fcollonval
David Brochart	QuantStack	@davidbrochart
Steven Silvester	MongoDB	@blink1073
Kiersten Stokes	IBM	@kiersten-stokes
Luciano Resende	Apple	@lresende
Johan Mabille	QuantStack	@JohanMabille

Agenda

Reminder call for proposal for JupyterCon 2023 is December 15th.
Jupyter Executive Council election is going on right now: December 4 AoE deadline. If you are on a Jupyter Council, please vote.
Extract out kernels service to a separate package.
Frederic (need to drop quickly but I'll try to come back before the end)
- Issue seen on JupyterLab that may be related to the Websocket change in v2rc
  failed: Error during WebSocket handshake: Sent non-empty 'Sec-WebSocket-Protocol' header
- Pull request to add sponsor badge on jupyter-server repositories
  
  We did it for example on the GitHub jupyterlab organization. IPython has some sponsor badge too.
Zach
- Jupyter Server 2.0 Release Announcement
  - https://hackmd.io/Rundu9eyR9qjdD_LNHJAcg
  - Check for deprecations, future warnings, etc. Let's diff 1.x vs. main looking for major changes.
Steve
- pytest-jupyter is now available to replace jupyter_server.pytest_plugin
- Coverage is now above 80%. We also added coverage and downstream to auto-merge criteria. Coverage will fail if it drops by 1%.
Johan
- Kernel handshaking pattern (https://github.com/jupyter/enhancement-proposals/pull/66)
  - Ran out of time - added to next week's agenda

Zsailer commented 1 year ago

December 8th, 2022

Name	affiliation	username
Zach Sailer	Apple	@Zsailer
Johan Mabille	QuantStack	@JohanMabille
Steven Silvester	MongoDB	@blink1073
Kevin Bates	IBM	@kevin-bates
Andrii Ieroshenko	AWS	@andrii-i
Afshin T. Darian	QuantStack	@afshin
Piyush Jain	AWS	@3coins

Agenda

Johan
- Kernel handshaking pattern (https://github.com/jupyter/enhancement-proposals/pull/66)
Kevin
- Archiving nb2kg has no dissenters, so I'd like to move forward
- I'll be out from tomorrow afternoon (12/9) until January 3. Happy holidays and New Year to everyone! :tada:
Steve
- Using ruff, less pre-commit.
- Cool thing I saw for debugging: https://github.com/cool-RR/PySnooper. Add a decorator and it prints variable state transitions and executed lines.
- We should allow pending kernels to be interrupted, for the case when you "Restart and Run All" and want to interrupt.
Zach
- Jupyter Server 2.0 is released! Congrats, folks!

jess-x commented 1 year ago

December 15th, 2022

Name	affiliation	username
Zach Sailer	Apple	@Zsailer
Andrii Ieroshenko	AWS	@andrii-i
Steven Silvester	MongoDB	@blink1073
David Brochart	QuantStack	@davidbrochart
Afshin T. Darian	QuantStack	@afshin
Johan Mabille	QuantStack	@JohanMabille
Jessica Xu	Cal Poly	@jess-x

Agenda

Zach
- Holiday schedule
  - We're planning to cancel both meetings.
  - Zach will remove from the Jupyter calendar.
- JupyterCon Proposal
  - I'll be working on this proposal today. If anyone would like to review it, I'll share a hackmd later.
  - David and Zach will be authors. Possibly Kevin?
David
- Jupyter kernel sub-shells JEP
- Looking for a shepherd. If anyone is interested, please reach out!
- Probably wait until after the holidays to review more closely.
- Question: Does the Jupyter messaging protcol define a "message not known" response for the control channel?
  - If it doesn't, we should add this to the protocol to make it easier to add new message types.
  - New JEP? <= YES ;)
Steve
- Linting - need to keep pre-commit and pyproject versions in sync, especially since ruff is still alpha.
- Asyncio - accidental API change in 3.10.9, 3.11.1, should be reverted. cf https://github.com/jupyter/jupyter_client/pull/902#pullrequestreview-1218834287

Previous