search

jupyter-server / team-compass

A repository for team discussion, syncing, and meeting notes.
https://jupyter-server-team-compass.readthedocs.io
BSD 3-Clause "New" or "Revised" License
14 stars 8 forks source link

Move `jupyterlab-lsp` server extension into `jupyter-server` organization #30

Closed trungleduc closed 1 year ago

trungleduc commented 2 years ago

There is an ongoing effort to add the support of the Language Server Protocol into core JupyterLab.

  1. Michał Krassowski opened a JEP (#72) proposing the adoption of LSP as part of Jupyter for notebooks. This was approved and merged in September 2021.

  2. Most of the work on LSP in Jupyter lives in the jupyterlab-lsp project, mostly maintained by Michał Krassowski (@krassowski) and Nick Bollweg (@bollwyvl ).

  3. I have been working on integrating some foundational parts of the logic of jupyterlab-lsp in core JupyterLab. In PR https://github.com/jupyterlab/jupyterlab/pull/12534, core components of the jupyterlab-lsp frontend extension handling the language server initialization and communication are moved into a new "lsp" package of JupyterLab. This work has already been extensively discussed in dedicated meetings with the developers of jupyterlab-lsp

  4. A natural next step would be to create a new repository in jupyter-server incorporating the pure server-side parts of jupyterlab-lsp(jupyter-lsp), and make it a dependency of jupyterlab-server (https://github.com/jupyterlab/jupyterlab_server/pull/282).

For reference, a JupyterLab team compass issue is opened here on the same subject: https://github.com/jupyterlab/team-compass/issues/148. Ping @bollwyvl and @krassowski, please feel free to comment or correct me if I misrepresented anything.

Votes

welcome[bot] commented 2 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

Zsailer commented 2 years ago

Sorry there hasn't been any movement on this. Let's discuss this again at our next meeting.

Pinging the @jupyter-server/jupyter-server-council to review this proposal and respond.

ellisonbg commented 2 years ago

Can someone give me permissions to this repo so I can vote...

Zsailer commented 2 years ago

:+1: @ellisonbg, just sent you an invitation to join the Jupyter Server org.

krassowski commented 2 years ago

A potential downside of this proposal is that moving issues between organizations is annoying. We often bump into this for notebook/lab/server during Thursday triage meetings (and often no one has sufficient permissions to ask our friend meseeksdev to move issues), and I suspect it might be an issue with LSP which under this proposal will live in 3 organizations for some time: JupyterLab (core), jupyter-lsp (extra features), jupyter-server and users will have no clue where to report.

Zsailer commented 2 years ago

@krassowski yes, this is a great point.

This issue was mentioned during the Jupyter Server team meeting where this org transfer was first proposed. I think you and the rest of the LSP maintainers should definitely take some time to consider if this is the best move forward for the project.

In the meantime, we can continue the vote here. That way, we will know if the server team is willing to receive the (server-side) project as something they will shepherd.

If it's accepted, the LSP maintainers can still decide they don't want to do the transfer after all.

krassowski commented 2 years ago

Just to clarify, I was not saying that I oppose the move, but that it might make our lives easier if we have that repo in jupyter-lsp organisation.

Some other points:

I am really looking forward to moving the server extension out of the current monorepo at https://github.com/jupyter-lsp/jupyterlab-lsp - it would simplify moving to jupyter-releaser, dealing with changelogs and also make first contributions easier.

I think I prefer if that would be under https://github.com/jupyter-lsp organization, but I don't feel strongly about it. @trungleduc what do you think? If you are available, let's aim to get this done by the end of next week.

trungleduc commented 2 years ago

Hi @krassowski, thanks for your clarification. I have no objection to keeping the jupyter-lsp server extension in the jupyter-lsp organization. Since the lsp related development will continue to happen on both jupyterlab and jupyter-lsp org for a period, I think we can postpone the transfer to the jupyter-server org. And as you said, I also want to move the server extension outside the monorepo jupyterlab-lsp. I'm on other stuff this week but I can get back to it next week.

damianavila commented 2 years ago

Hi @krassowski, thanks for your clarification. I have no objection to keeping the jupyter-lsp server extension in the jupyter-lsp organization.

It seems there is agreement about keeping the jupyter-lsp server extension in the jupyter-lsp organization. Then, should we close this one?

vidartf commented 1 year ago

Closing as the discussion seems to have concluded