search

jupyter-widgets-contrib / ipycanvas

Interactive Canvas in Jupyter
https://ipycanvas.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
686 stars 64 forks source link

missing dependency `jupyterlab-manager` #187

Closed goekce closed 3 years ago

goekce commented 3 years ago

dear @martinRenou I noticed that ipycanvas does not work without jupyterlab_widgets, but jupyterlab_widgets is not listed in setup.py as a dependency:

https://github.com/martinRenou/ipycanvas/blob/30ccca2a7cae2ead7840ea391e3a7f7fde44a73a/setup.py#L96-L101

does setup.py not support jupyterlab related deps?

martinRenou commented 3 years ago

Hello :)

jupyterlab_widgets is a dependency of ipywidgets, see https://github.com/jupyter-widgets/ipywidgets/blob/master/setup.cfg#L43 so everything should be fine.