search

jupyter-widgets-contrib / ipycanvas

Interactive Canvas in Jupyter
https://ipycanvas.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
688 stars 64 forks source link

fix wrong ver #234

Closed DerThorsten closed 2 years ago

DerThorsten commented 2 years ago

currently ipycanvas does not start when installed from conda when using 0.10.0 the debug output shows 

2523.cf94b68f6edde7eefd61.js:1 Uncaught (in promise) Error: Module ipycanvas, semver range ^0.9.0 is not registered as a widget module
    at x.loadClass (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/523.cf94b68f6edde7eefd61.js:1)
    at x.<anonymous> (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1
    at Object.next (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1
    at new Promise (<anonymous>)
    at S (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at x.e._make_model (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at x.<anonymous> (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1
2523.cf94b68f6edde7eefd61.js:1 Uncaught (in promise) Error: Module ipycanvas, semver range ^0.9.0 is not registered as a widget module
    at x.loadClass (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/523.cf94b68f6edde7eefd61.js:1)
    at x.<anonymous> (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1
    at Object.next (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1
    at new Promise (<anonymous>)
    at S (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at x.e._make_model (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at x.<anonymous> (lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1)
    at lab/extensions/@jupyter-widgets/jupyterlab-manager/static/272.9d70a85a9abe209402d0.js:1

I think this is due to a missing version bump in ipycanvas/_frontend.py. I think this makes the 0.10.0 release a broken one

martinRenou commented 2 years ago

Thanks for catching it. That's annoying the CI didn't catch it, we should make the CI more robust and use Galata.