search

jupyter-widgets-contrib / ipycanvas

Interactive Canvas in Jupyter
https://ipycanvas.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
685 stars 62 forks source link

The docs link to github needs updating #341

Closed dannystaple closed 2 months ago

dannystaple commented 8 months ago

In the readthedocs page - eg https://ipycanvas.readthedocs.io/en/latest/api.html?highlight=measure%20text#ipycanvas.canvas.Canvas.font, there is a link on the top right to the GitHub repository for the project.

This currently still refers to the old repository with the "This repository has been moved" note. Perhaps update this to the current project location?

dannystaple commented 8 months ago

Looking at https://github.com/jupyter-widgets-contrib/ipycanvas/blob/master/docs/conf.py - this appears to have the right path. Have the docs not been regenerated since that?

dannystaple commented 8 months ago

I presume this was the last build - https://readthedocs.org/projects/ipycanvas/builds/21398944/. Following the link back to github, it should have the right link - https://github.com/jupyter-widgets-contrib/ipycanvas/commit/b5cf121bc7bae9c8909dbb3e18a61c2591461d51#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3

dannystaple commented 8 months ago

This doc from the build - https://ipycanvas.readthedocs.io/en/master/ - has the right link. Ah - so latest is likely based on https://github.com/jupyter-widgets-contrib/ipycanvas/releases/tag/0.13.1? Releasing at some point would I presume make that the latest, and show the correct link. Fixing this requires a release only.

parmentelat commented 2 months ago

yeah, ran into that too it'd help to have the default entry in readthedocs show the right link :)

martinRenou commented 2 months ago

This should now be fixed, thanks!