jupyter-widgets-contrib / ipygany

3-D Scientific Visualization in the Jupyter Notebook
BSD 3-Clause "New" or "Revised" License
487 stars 53 forks source link

Nothing shown? #110

Closed dschwoerer closed 3 years ago

dschwoerer commented 3 years ago

I tried to install ipygany in Fedora 34 using pip, but I just don't get anything shown.

I load a PolyMesh.from_vtk and then create a Scene.

I did see:

Scene(children=[PolyMesh(data=[], triangle_indices=array([5901, 2333, 2162, ..., 1452, 4105, 3028], dtype=uint…

but after installing ipywidgets, that is now gone, and I am back to seeing nothing.

I am seeing an error of Could not instantiate widget in firefox's console, but I do not understand the output.

Is there anything else I need to install, besides ipywidgets that is not pulled in automatically?

martinRenou commented 3 years ago

ipywidgets and all other dependencies (except vtk which is optional) get pulled automatically.

Are you using Jupyter Notebook or JupyterLab or something else?

dschwoerer commented 3 years ago

I am using Jupyter Notebook (python3-notebook-6.1.6-2.fc34.noarch).

I had to run: jupyter nbextension enable --py ipygany

or directly put this in my ~/.jupyter/nbconfig/notebook.json :

{
  "load_extensions": {
    "jupyter-js-widgets/extension": true,
    "ipygany/extension": true
  }
}

After that, and reloading the page, it works :+1:

Should that be documented? Or did I just miss it?

I have notebook version 6.1.6 - which should be "5.3 and above"?

martinRenou commented 3 years ago

This should get installed automatically by ipygany, see https://github.com/QuantStack/ipygany/blob/master/ipygany.json and https://github.com/QuantStack/ipygany/blob/master/setup.py#L51

So I suspect ipygany didn't get installed under the same path as your jupyter installation. Maybe you ran one of the pip install command with --user, or you installed one package in a virtual env and not the other.

dschwoerer commented 3 years ago

So I suspect ipygany didn't get installed under the same path as your jupyter installation.

Yes, ipygany isn't packaged yet for fedora, I cannot install it with the package manger.

Maybe you ran one of the pip install command with --user, or you installed one package in a virtual env and not the other.

No, but but pip defaults to user install if the system path isn't write-able, which is not recommended.

Would it make sense to remove the comment, to avoid a lot of trouble in corner cases? Or are there bad consequences if it is run, without being needed?

martinRenou commented 3 years ago

Yes, ipygany isn't packaged yet for fedora, I cannot install it with the package manger.

Oh, I see. It is unlikely to be packaged for fedora though. I'd suggest using pip or conda (even better) and using virtual environments for Python packages, instead of installing everything on your root, this will save you from many issues.

Would it make sense to remove the comment, to avoid a lot of trouble in corner cases?

Sorry, which comment are you talking about?

dschwoerer commented 3 years ago

Yes, ipygany isn't packaged yet for fedora, I cannot install it with the package manger.

Oh, I see. It is unlikely to be packaged for fedora though. I'd suggest using pip or conda (even better) and using virtual environments for Python packages, instead of installing everything on your root, this will save you from many issues.

I prefer to only have one package manager to update and manage all my packages, so I would prefer having it packaged ;-)

Would it make sense to remove the comment, to avoid a lot of trouble in corner cases?

Sorry, which comment are you talking about?

Sorry, should have mentioned that earlier: https://github.com/QuantStack/ipygany/blame/stable/docs/source/installation.rst#L22

martinRenou commented 3 years ago

I prefer to only have one package manager to update and manage all my packages, so I would prefer having it packaged ;-)

Yeah. Choose conda then ;) You'll have almost the entire Python stack available from conda-forge. You could even use micromamba: https://github.com/mamba-org/mamba#micromamba which will very easily allow you to make scoped conda environments.

Feel free to package ipygany for Fedora if you want it though! 😃 But I personally don't have the bandwidth to maintain the package for another package manager.

Sorry, should have mentioned that earlier:

Yeah... We shouldn't remove the comment IMO. This should not be needed for a classic installation.