search

jupyter-widgets-contrib / ipysheet

Jupyter handsontable integration
MIT License
543 stars 68 forks source link

Fix incompatibility with ipywidgets 8.x #233

Closed weiglszonja closed 2 years ago

weiglszonja commented 2 years ago

Attemps to resolve #231

Changed the widget registration based on the tutorial from the latest ipywidgets.

Comments and help are welcome.

martinRenou commented 2 years ago

Thanks for opening a PR!

This will unfortunately not be enough to make it work with ipywidgets 8. There is also probably some code to change under the src directory in the TypeScript code.

If you want to have a try doing it, you can take e.g. this PR as guidance.

I can also find the time to take over your PR and change the TypeScript part if you prefer.

weiglszonja commented 2 years ago

@martinRenou Thank you for letting me know, unfortunately I wasn't able to test it thoroughly whether I solved all the issues. I would gladly accept your help and hand this PR over to you, as I'm not familiar with TypeScript.

Let me know how it goes, I'll keep an eye on in case you'd need anything to assist in.

bnavigator commented 2 years ago

Any news on the typescript part?