Improve view of returned DataFrame from get_visible_data()

jupyter-widgets / ipydatagrid

Fast Datagrid widget for the Jupyter Notebook and JupyterLab

BSD 3-Clause "New" or "Revised" License

580 stars 51 forks source link

Improve view of returned DataFrame from get_visible_data() #218

Closed ibdafna closed 3 years ago

ibdafna commented 3 years ago

Signed-off-by: Itay Dafna i.b.dafna@gmail.com

This PR makes the index and column names of dataframes returned from the grid.get_visible_data() method to be consistent with the index and column names of the original DataFrame passed to the grid constructor.

ibdafna commented 3 years ago

@gaborbernat I'll add one in a separate PR

EDIT: actually we do have tests for these methods, but get_visible_data() needs a DOM element. I'll need to think further if there's a way around it. Perhaps mocking it.