Closed ibdafna closed 3 years ago
Not ready for review yet: there are some quirks with stale colours applied to header renderers when changing styles or setting the header renderer to None
. Working on that.
Tested everything is working as expected. Also squeezed in a bugfix unrelated to this PR where setting a header_renderer
initially, but unsetting by by setting header_renderer=False
does not actually remove the renderer.
I also updated one of the tests which failed due to changes in the logic - also tested everything is working as expected data-wise including sorting, filtering and changing the data set. @kaiayoung would be good if you could take a look too, just in case I missed something.
EDIT: the test I edited is from a change unrelated to this PR (pre 1.0.7), which was not detected by the CI for some reason.
Signed-off-by: Itay Dafna i.b.dafna@gmail.com
This PR adds support for corner header renderers via a
corner_renderer
traitlet. The current API behaviour is not changed - users who do not pass to the constructor or set thecorner_renderer
property on theDataGrid
object, but do passheader_renderer
will see the header renderer applied to the corner header too. If they do set acorner_renderer
property then it will will override the header renderer - only applies to the corner header!