Fix an issue in 1.1.4 / Release 1.1.5

jupyter-widgets / ipydatagrid

Fast Datagrid widget for the Jupyter Notebook and JupyterLab

BSD 3-Clause "New" or "Revised" License

580 stars 51 forks source link

Fix an issue in 1.1.4 / Release 1.1.5 #270

Closed ibdafna closed 3 years ago

ibdafna commented 3 years ago

The logic for index_name in 1.1.4 didn't account for index names of newly passed DataFrames after the grid has been instantiated. This PR adds logic for that and releases 1.1.5 with this fix.

ibdafna commented 3 years ago

@gaborbernat Right with you buddy! Added some tests. I think it's time to introduce some visual regression testing, too. Reckon we could set some time aside to think about how to integrate with our CI?