search

jupyter-widgets / ipydatagrid

Fast Datagrid widget for the Jupyter Notebook and JupyterLab
BSD 3-Clause "New" or "Revised" License
579 stars 51 forks source link

Fix for #284 not working in Safari (mac/ios) #353

Closed mangecoeur closed 2 years ago

mangecoeur commented 2 years ago

New PR after I messed up my repo ;)

Describe your changes Replaced the lookbehind regex in vegaexpr.ts with a normal regex group. Since the resulting matches are anyway re-processed with another regex, the extra capture group in the match shouldn't affect the final result.

Testing performed Ran python and js tests, confirmed working in jupyter lab in firefox and safari.

ibdafna commented 2 years ago

Thank you! 🤘🚀

ibdafna commented 2 years ago

I'll cut a release on the week beginning Oct 17th!