jupyter-widgets / ipydatagrid

Fast Datagrid widget for the Jupyter Notebook and JupyterLab
BSD 3-Clause "New" or "Revised" License
580 stars 51 forks source link

Filter/sort controls not selectable in latest version #446

Closed zwelz3 closed 7 months ago

zwelz3 commented 1 year ago

Describe the bug Filter/sort controls not selectable in latest ipydatagrid release.

To Reproduce Steps to reproduce the behavior:

  1. Install ipydatagrid==1.2.0
  2. Run default DataGrid.ipynb example
  3. Try to click on the filter/sort icon for a column
  4. Observe no UI is triggered for filter/sort column

Expected behavior Prior to 1.2.0 clicking the column icon would open a UI (see below)

image

Environment (please complete the following information):

jgunstone commented 1 year ago

just double checked this and have the same problem - the version on binder isn't working in the way described

aloneguid commented 1 year ago

same here!

kaizenloop commented 1 year ago

Also having this issue in the same way described

aloneguid commented 1 year ago

I had to downgrade to previous version, works fine.

martinRenou commented 1 year ago

I think we need to revert https://github.com/bloomberg/ipydatagrid/pull/441 for a patch release as it seems to have broken the button entirely.

ywahl commented 10 months ago

When will this PR be included in a next official release?

martinRenou commented 10 months ago

When https://github.com/bloomberg/ipydatagrid/pull/469 gets merged :)

cmc-emmet commented 7 months ago

@martinRenou - given that we're now at version 1.3.1 has this Issue been resolved?

martinRenou commented 7 months ago

Indeed, this has been resolved in 1.2.1.

Thanks!