jupyter-widgets / ipydatagrid

Fast Datagrid widget for the Jupyter Notebook and JupyterLab
BSD 3-Clause "New" or "Revised" License
579 stars 51 forks source link

Image renderer #470

Closed martinRenou closed 8 months ago

martinRenou commented 10 months ago

Fix https://github.com/bloomberg/ipydatagrid/issues/253

This only works with JupyterLab 4.1.0 which ships a recent enough version of Lumino.

Screenshot from 2024-01-18 12-55-13

martinRenou commented 10 months ago

This only works with JupyterLab 4.1.0b1 which ships a recent enough version of Lumino. We need a strategy for it to fail for older versions.

We cannot fail Python side:

I decided to fail JavaScript side in the case where the import of ImageRenderer fails:

Screenshot from 2024-01-18 15-24-34

martinRenou commented 10 months ago

We can probably wait before merging/releasing this, as JupyterLab 4.1 is not even out yet.

martinRenou commented 8 months ago

Visual regression tests will be fixed by https://github.com/bloomberg/ipydatagrid/pull/482