jupyter-widgets / ipyleaflet

A Jupyter - Leaflet.js bridge
https://ipyleaflet.readthedocs.io
MIT License
1.48k stars 363 forks source link

Styles are still loaded even when Jupyterlab's --future-skip-styles-for-disabled flag is used. #1103

Open suganya-sk opened 1 year ago

suganya-sk commented 1 year ago

TLDR - styles are still loaded even when the lab extension is disabled and Jupyterlab's --future-skip-styles-for-disabled flag is used.

Jupyterlab 3.6.0 recently introduced an option --future-skip-styles-for-disabled to avoid loading styles of disabled extensions. This flag is about to become the default in Jupyterlab 4.0 - see section "Future changes" here. This is a much-anticipated step in addressing the performance issues of Jupyterlab.

However, when I disable jupyter-leaflet and start Jupyterlab 3.6.1 using the flag described above, I can see that the styles of this extension are still loaded onto the page, since the styles are loaded directly here - link while Jupyterlab's recommendation seems to be to define the location of CSS in package.json - link

Seeing this is incompatible with a Jupyterlab option that is about to become default, can this be fixed please?