search

jupyter-widgets / ipyleaflet

A Jupyter - Leaflet.js bridge
https://ipyleaflet.readthedocs.io
MIT License
1.47k stars 361 forks source link

ipyleaflet not working properly with JupyterLab 4.x #1125

Closed giswqs closed 8 months ago

giswqs commented 1 year ago

It appears that JupyterLab 4.x breaks some ipyleaflet functionality. Changing map attributes (e.g., zoom, center) has no effect. It works fine in VS Code.

In JupyterLab: Peek 2023-07-14 23-10

In VS Code: Peek 2023-07-14 23-13

martinRenou commented 10 months ago

Thank you for opening an issue. Would you be able to provide the JavaScript console errors, if there are any?

giswqs commented 9 months ago

See https://github.com/jupyterlab/jupyterlab/issues/14829#issuecomment-1671370797

dfguerrerom commented 8 months ago

@giswqs you might want to see https://github.com/openforis/sepal/issues/304.

jhgoebbert commented 8 months ago

I came across this fork which claims to run with JupyterLab>4. Perhaps it is possible to merge the commits from there.
https://github.com/cdanielw/ipyleaflet

cdanielw commented 8 months ago

Together with that fork, I uploaded a pre-built release we use in SEPAL, as an interim solution:

pip install https://github.com/cdanielw/ipyleaflet/releases/download/0.17.4/ipyleaflet-0.17.4-py3-none-any.whl

I never bothered to make a pull request, as I assume the ipyleaflet guys are on-top-of this issue. I just needed an immediate way to get this running.

martinRenou commented 8 months ago

If you could open a PR that would be great. We need help maintaining this.