jupyter-widgets / ipyleaflet

A Jupyter - Leaflet.js bridge
https://ipyleaflet.readthedocs.io
MIT License
1.47k stars 359 forks source link

ipyleaflet is broken (missing file on CDN) #1192

Closed naschmitz closed 1 month ago

naschmitz commented 2 months ago

The jupyter-leaflet@0.19 implementation no longer exists on the jsdelivr CDN. I get a 404 when loading https://cdn.jsdelivr.net/npm/jupyter-leaflet@0.19/dist/index.js. ipyleaflet was working fine yesterday, and today it's not.

giswqs commented 2 months ago

@martinRenou @maartenbreddels it seems the newest ipyleaflet v0.19.0 is broken. It doesn't work on Colab

maartenbreddels commented 2 months ago

@iisakkirotko do you want to take a look at this?

iisakkirotko commented 2 months ago

Hi everyone! Looks to me like the dist folder is missing from version 0.19 of the package, see here. The release process is done manually as well, so I think @martinRenou needs to take a look.

maartenbreddels commented 1 month ago

The issue was fixed in https://github.com/jupyter-widgets/ipyleaflet/commit/fd02487e1402de6f947b58d79720ebda27cf593d, and I released version 0.19.1, which contains this fix.

Due to the loose dependency in ipyleaflet (using semver ^0.19.0), voila will pick up 0.19.1 from the CDN, so you might not need to upgrade.

giswqs commented 1 month ago

Thank you very much for fixing it. I can confirm that now ipyleaflet works properly on Colab

martinRenou commented 1 month ago

Thanks a lot @maartenbreddels !