jupyter-widgets / ipyleaflet

A Jupyter - Leaflet.js bridge
https://ipyleaflet.readthedocs.io
MIT License
1.49k stars 363 forks source link

To make the float zoom levels useful for Vector Tile Layer #591

Closed omanges closed 4 years ago

omanges commented 4 years ago

Even though the zoom level trait has been made Float in the Vector Tile Layer support feature (https://github.com/jupyter-widgets/ipyleaflet/pull/544), the zoom only changes on a integer value, for example, map actually changes only on 1.0, 2.0, 3.0 ..., rather than changing on any floating zoom, as floating zoom levels are possible for Vector Tile.

davidbrochart commented 4 years ago

Looks like we need support for https://leafletjs.com/reference-1.6.0.html#map-zoomdelta

martinRenou commented 4 years ago

It should be straightforward to expose this zoom_delta option to Python

omanges commented 4 years ago

@martinRenou assign this to me, I can try this.

omanges commented 4 years ago

I think we should also implement the https://leafletjs.com/reference-1.6.0.html#map-zoomsnap, zoomSnap

omanges commented 4 years ago

Works for me now image

zxdawn commented 1 year ago

Is it possible to make it also work for the scroll wheel?