jupyter-widgets / ipyleaflet

A Jupyter - Leaflet.js bridge
https://ipyleaflet.readthedocs.io
MIT License
1.49k stars 363 forks source link

Converting units in Velocity #603

Open k-choonkiat opened 4 years ago

k-choonkiat commented 4 years ago

I would like to convert the units from m/s to Knots and have tried to do so using Units in Velocity but it didnt work

davidbrochart commented 4 years ago

Yes, lots of things seem to be broken in Velocity. Some traits are not synced with the front-end, including units. I tried to set speedUnit in display_options but it has no effect either... I'll look at it.

davidbrochart commented 4 years ago

Actually units should be taken into account through https://github.com/jupyter-widgets/ipyleaflet/blob/master/ipyleaflet/xarray_ds.py, but it's not.

SchoolProjBase commented 4 years ago

@davidbrochart thanks for your reply. Is there any update on this issue? I would like to tweak the units for velocity layer.

davidbrochart commented 4 years ago

Sorry, I didn't have time to work on it yet.

SchoolProjBase commented 4 years ago

Is there any hint or clue to resolve this issue?

davidbrochart commented 4 years ago

Sorry, I've been busy. Do you want to give it a try?