Closed bernhard-42 closed 3 years ago
Hey @bernhard-42 yes absolutely. This has just been a question of bandwidth as we maintain many extensions. If you feel like opensing a PR to port it to 2.0, that would be awesome!
Do you have an idea of what would need to be updated for this to work in JupyterLab >=2?
Also, see the open PR: #38
@kylebarron Yeah, I also try to come up with a pull request. Took me quite some time to get the karma tests running (I have no idea of karma and little experience with typescript). But now it works and I can see whether I can port Sidecar to JL 2.0
No promises ;-)
No, I'm saying there's already a Pull Request open, so you most likely don't need to spend more time on your own branch.
I know, I copied some of the stuff from this PR, but didn't understand every change, so I started from scratch to see what the changes meant - a little bit of a learning experience ...
Is this issue closed by https://github.com/jupyter-widgets/jupyterlab-sidecar/pull/38 ?
Presumably, though I haven't tested it.
Currently the prerequisites in
package.json
arewhich from my understanding are not compatible with Jupyterlab 2.x And there might be other changes necessary ...