search

jupyter-widgets / jupyterlab-sidecar

A sidecar output widget for JupyterLab
BSD 3-Clause "New" or "Revised" License
247 stars 39 forks source link

Will jupyterlab-sidecar be further maintained and ported to Jupyterlab 2.x? #41

Closed bernhard-42 closed 3 years ago

bernhard-42 commented 4 years ago

Currently the prerequisites in package.json are 

"@jupyter-widgets/jupyterlab-manager": "^1.0.0",
"@jupyterlab/application": "^1.0.0"

which from my understanding are not compatible with Jupyterlab 2.x And there might be other changes necessary ...

SylvainCorlay commented 4 years ago

Hey @bernhard-42 yes absolutely. This has just been a question of bandwidth as we maintain many extensions. If you feel like opensing a PR to port it to 2.0, that would be awesome!

kylebarron commented 4 years ago

Do you have an idea of what would need to be updated for this to work in JupyterLab >=2?

kylebarron commented 4 years ago

Also, see the open PR: #38

bernhard-42 commented 4 years ago

@kylebarron Yeah, I also try to come up with a pull request. Took me quite some time to get the karma tests running (I have no idea of karma and little experience with typescript). But now it works and I can see whether I can port Sidecar to JL 2.0

No promises ;-)

kylebarron commented 4 years ago

No, I'm saying there's already a Pull Request open, so you most likely don't need to spend more time on your own branch.

bernhard-42 commented 4 years ago

I know, I copied some of the stuff from this PR, but didn't understand every change, so I started from scratch to see what the changes meant - a little bit of a learning experience ...

psychemedia commented 4 years ago

Is this issue closed by https://github.com/jupyter-widgets/jupyterlab-sidecar/pull/38 ?

kylebarron commented 4 years ago

Presumably, though I haven't tested it.