search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

SphereGeometry missing many parameters #104

Closed iliyang closed 7 years ago

iliyang commented 7 years ago

I like how pythreejs provides a very thin wrapper around three.js. This, I think, facilitates maintenance.

The SphereGeometry class in three.js has a bunch of parameters:

SphereGeometry(radius, widthSegments, heightSegments, phiStart, phiLength, thetaStart, thetaLength)

but the SphereGeometry class in pythreejs only supports the radius param. That's a pity because the sphere tessellation precision cannot be controlled (done via the widthSegments and heightSegments params in three.js).

Is there a plan to add such support? And is there a list of what's supported and what not? Such a list could facilitate others to contribute to keeping pythreejs up-to-date.

honorabel commented 7 years ago

This is actually the goal of a big initiative w/ the project to autogenerate a lot of the wrappers to match the threejs api much more closely. It is actively being worked on right now.

So, to answer your question, yes, that's in the plan :)

iliyang commented 7 years ago

Yey! I'm absolutely loving pythreejs and it is great to hear new and exciting stuff is coming!

vidartf commented 7 years ago

This should now be fixed via #88. Please reopen if there's anything I missed.