jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

Buffer attributes/geometry #113

Closed vidartf closed 7 years ago

vidartf commented 7 years ago

Adds support for buffer attributes and geometries.

Point worth noting:

See the updated example notebook(s) for behavior.

Based on #108.

vidartf commented 7 years ago

Note that with this PR, the autogen branch should be at the same level (nearly?) as the current master in terms of functionality, and that after the currently open PRs to the autogen branch are dealt with, one can consider merging the autogen branch into master.

vidartf commented 7 years ago

Emphasis: This PR adds the requirement that the ipydatawidgets frontend extension is installed as well.

jasongrout commented 7 years ago

@vidartf - feel free to merge this in if you feel it's ready.

honorabel commented 7 years ago

Apologies for not being able to review as much these days. I'm so pumped you guys are really taking some huge steps with improving this lib! The idea that buffer data can be passed back and forth efficiently is huge and I can only imagine what kind of cool demos this might enable!

vidartf commented 7 years ago

Just wanted to make sure you were comfortable adding a dependency on another extension.

jasongrout commented 7 years ago

Just wanted to make sure you were comfortable adding a dependency on another extension.

I'm not opposed to the idea.