Closed vidartf closed 7 years ago
Note that with this PR, the autogen branch should be at the same level (nearly?) as the current master in terms of functionality, and that after the currently open PRs to the autogen branch are dealt with, one can consider merging the autogen branch into master.
Emphasis: This PR adds the requirement that the ipydatawidgets frontend extension is installed as well.
@vidartf - feel free to merge this in if you feel it's ready.
Apologies for not being able to review as much these days. I'm so pumped you guys are really taking some huge steps with improving this lib! The idea that buffer data can be passed back and forth efficiently is huge and I can only imagine what kind of cool demos this might enable!
Just wanted to make sure you were comfortable adding a dependency on another extension.
Just wanted to make sure you were comfortable adding a dependency on another extension.
I'm not opposed to the idea.
Adds support for buffer attributes and geometries.
Point worth noting:
ipydatawidgets
, which is a helper package for arrays and widgets for sharing arrays between different widgets.PlainBufferGeometry
as a buffer geometry class that syncs its attributes to the python side.PlainBufferGeometry.from_ref
that initializes a newPlainBufferGeometry
as either a copy of anotherBufferGeometry
, or as a conversion of a regularGeometry
. This copy should then sync its attributes back to the kernel side.from_ref
, it introduces machinery for creating new widget models from the JS side.See the updated example notebook(s) for behavior.
Based on #108.