search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

fix widgets disappearing after several displays of a renderer #169

Closed jsb closed 6 years ago

jsb commented 6 years ago

There were a few minor bugs in the KeyedCollection and the acquire function causing freePool not to be used and this.numCreated exceeding MAX_RENDERERS after a few displays.

vidartf commented 6 years ago

Thanks! For reference: I did some further cleanup in https://github.com/jovyan/pythreejs/commit/5cc5dcd334e52c9aae68dc8553795c07e8f6d8ca after merging.

vidartf commented 6 years ago

Oh, and 4cb120c73dbfe09fe0bf73623df2b2e94f160f46 😅