search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

Conda-forge package at version 0.4.1 #183

Closed JuanCab closed 6 years ago

JuanCab commented 6 years ago

Since you mention it in the installation instructions, I thought I would let you know

conda install -c conda-forge pythreejs

installs version 0.4.1, not the current 1.0.0. Someone needs to update the condo-forge package.

vidartf commented 6 years ago

We recently identified the issue to be that a new dependency was not yet on conda. We're working on getting that up as of yesterday, so hopefully it will be solved by the end of the week!

vidartf commented 6 years ago

Got this through just now. Feel free to test it and let me know if there are any issues!

JuanCab commented 6 years ago

Tried pip uninstalling pythreejs and then installing via conda and got

Downloading and Extracting Packages
pythreejs-1.0.0      |  627 KB | ####################################### | 100%
ipyscales-0.2.2      |   77 KB | ####################################### | 100%
ipydatawidgets-3.1.0 |   37 KB | ####################################### | 100%
Preparing transaction: done
Verifying transaction: done
Executing transaction: - + /Users/juan/anaconda3/bin/jupyter-nbextension enable pythreejs --py --sys-prefix
Enabling notebook extension jupyter-threejs/extension...
      - Validating: problems found:
        - require?  X jupyter-threejs/extension

Any idea why it can't find the pythreejs notebook extension?

vidartf commented 6 years ago

If you uninstall both with pip and conda, and call jupyter nbextension list, does pythreejs show up? There might be some configuration conflict.

vidartf commented 6 years ago

Note: Locally (Windows) I'm getting

pythreejs-1.0. 100% |###############################| Time: 0:00:02 858.93 kB/s
Enabling notebook extension jupyter-threejs/extension...
      - Validating: ok

so it might be platform dependent. Which platform are you on?

JuanCab commented 6 years ago

I am doing all this on a macOS 11.3.5 installation.

I had uninstalled the pip version before calling for the conda install.

Uninstalling the conda version and reinstalling leads to the same problem, in fact, uninstalling (with conda) it reports

Executing transaction: | + /Users/juan/anaconda3/bin/jupyter-nbextension disable pythreejs --py --sys-prefix
Disabling notebook extension jupyter-threejs/extension...
      - Validating: problems found:
        - require?  X jupyter-threejs/extension

at which point jupyter nbextension list says 

      jupyter-threejs/extension disabled
    tree section

Looks like either pip uninstall pythreejs didn't clean up after itself or conda install is missing the extension.

I was able to reinstall pip install pythreejs and get the extension reactivated... I then explicitly jupyter nbextension uninstall jupyter-threejs and pip uninstall pythreejs before the conda install. Still getting the same error with the conda package.

vidartf commented 6 years ago

Thanks for helping debug this!

If you run

conda uninstall pythreejs
pip uninstall pythreejs
pip uninstall pythreejs
pip uninstall pythreejs
# yes, pip uninstall multiple times, it some times matter

Then:

These steps above you should also repeat for any directory returned by the command jupyter --paths.

These are the steps I personally follow when I want to make absolutely sure I clean out any old configuration.

Before reinstalling, confirm also that it is gone from jupyter nbextension list. At this point, updating conda could be nice to preclude some old issues (conda update conda). If the issue is still there when reinstalling pythreejs, please check the content of /Users/juan/anaconda3/share/jupyter/nbextensions if jupyter-threejs folder is there and report which files are in it.

JuanCab commented 6 years ago

I went through and

  1. did the multiple pip uninstalls (the 2nd and 3rd just reported Skipping pythreejs as it is not installed..
  2. No folder named jupyter-pythreejs existed in /Users/juan/anaconda3/share/jupyter/nbextensions
  3. The notebook.json has no mention of jupyter-pythreejs
  4. There is no jupyter-threejs.json in the notebook.d subdirectory.
  5. Checked all the directories listed by jupyter --paths (there were quite a few) Nothing obvious in terms of pythreejs or jupyter-threejs filenames and grep threejs * revealed no hidden mentions in files.
  6. Confirmed that jupyter nbextension list does NOT show it in the list any more (disabled or otherwise).
  7. I did conda update conda but I was already up to date. 👍

After all that, did a conda install pythreejs...

Downloading and Extracting Packages
pythreejs-1.1.0      |  631 KB | ####################################### | 100%
Preparing transaction: done
Verifying transaction: done
Executing transaction: | + /Users/juan/anaconda3/bin/jupyter-nbextension enable pythreejs --py --sys-prefix
Enabling notebook extension jupyter-threejs/extension...
      - Validating: problems found:
        - require?  X jupyter-threejs/extension

Still failed! So I went to the /Users/juan/anaconda3/share/jupyter/nbextensions directory, there is no jupyter-threejs directory (which I suspect is the problem). Oh, and just in case, I checked, I have write permission to the directory (I suspected as much, since pip install pythreejs does work).

JuanCab commented 6 years ago

On a positive note, it picked up version 1.1.0 of pythreejs. 😄

vidartf commented 6 years ago

Confirmed locally on OSX. Are you on OSX or linux?

JuanCab commented 6 years ago

macOS 10.13.5 (the most current release version) and Python 3.6.5 :: Anaconda custom (64-bit).

vidartf commented 6 years ago

Fix (workaround) added to feedstock in https://github.com/conda-forge/pythreejs-feedstock/pull/18 . Proper fix should be to setupbase.py to ensure that an exception in the npm install command to not prevent the handle_files command from running:

https://github.com/jupyter-widgets/pythreejs/blob/5c43fa983782a8a1fa29465caf42a86f5891b3c4/setupbase.py#L473-L479

vidartf commented 6 years ago

The next build should be done in less than half an hour. If you could please retry then and confirm that the issue is fixed, I would be much obliged!

JuanCab commented 6 years ago

Tried it again, still failed with same error. Any way to know if I waited long enough to get the current conda-forge package? It was pythreejs: 1.1.0-py36_0

vidartf commented 6 years ago

When it becomes _1 at the end it should be the new one.

On Thu, Jun 7, 2018, 17:46 Juan Cabanela notifications@github.com wrote:

Tried it again, still failed with same error. Any way to know if I waited long enough to get the current conda-forge package? It was pythreejs: 1.1.0-py36_0

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jupyter-widgets/pythreejs/issues/183#issuecomment-395469699, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfLKIJEoCzMjg8m7V92uPDqiou_JsPTks5t6UrQgaJpZM4UboPe .

vidartf commented 6 years ago

It should be out now: https://anaconda.org/conda-forge/pythreejs/files

JuanCab commented 6 years ago

When I look at it, that directory is NOT showing osx files version py36_1...

jasongrout commented 6 years ago

OS X builds typically take a longer time to build.

JuanCab commented 6 years ago

The OSX version has NOT posted on https://anaconda.org/conda-forge/pythreejs/files yet, I suspect something has interfered with its posting.

vidartf commented 6 years ago

I've traced it to the build failing. There is a very obscure error on Travis, where I'm currently trying to check with conda-forge about where the issue is. Very strange considering the OSX tests passed on the PR...

vidartf commented 6 years ago

Cross-linking the issue on the feedstock, this has now been fixed with 1.1.0_2!

vidartf commented 6 years ago

https://github.com/conda-forge/pythreejs-feedstock/issues/20

JuanCab commented 6 years ago

Confirmed it works, thanks!

vidartf commented 6 years ago

🎉