search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
936 stars 187 forks source link

Examples: radialSegments -> radiusSegments #251

Closed wstomv closed 5 years ago

wstomv commented 5 years ago

In https://github.com/jupyter-widgets/pythreejs/blob/952ab13c21ab19425328083f126bd51e1dc397ea/examples/Geometries.ipynb#L173 and other places, radialSegments appears, but this should be radiusSegments.

vidartf commented 5 years ago

Thanks for the report! There is definitely an error here, but the three.js docs/code should be considered the source of truth here. I'll add this to #253 shortly!

vidartf commented 5 years ago

Xref: https://github.com/mrdoob/three.js/pull/13509