jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
942 stars 188 forks source link

JupyterLab 1.0 update #281

Closed jasongrout closed 5 years ago

jasongrout commented 5 years ago

I think for this to work in JupyterLab 1.0, this line: https://github.com/jupyter-widgets/pythreejs/blob/4d2f2fa828c7184dc5a7d539ac879fbe2eb61375/js/package.json#L37

needs to be changed to

"@jupyter-widgets/base": "^1.2.5 || ^2",
vidartf commented 5 years ago

There are some other widget dependencies that needs to be updated first as well. They are in the pipeline.

jasongrout commented 5 years ago

Just curious, what else needs to be updated?

vidartf commented 5 years ago

jupyter-dataserializers

vidartf commented 5 years ago

Updated as a patch release! Please open issues if there any problems with it.