search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
934 stars 185 forks source link

fix traitlets5 compat #338

Closed vidartf closed 3 years ago

vidartf commented 3 years ago

Fixes #334 .

Traitlets 5 changed how self.default_value was used vs the dynamic default callback of the Instance trait type (in v5 default_value takes precedence over the dynamic default). ~This avoids us writing to that value, as I don't think we every rely on it.~ Here we ensure that the value we write is correct, so that ipywidgets sync logic is correct.

vidartf commented 3 years ago

CI failure is just because the Travis 3.9 binary is still missing.