search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
934 stars 185 forks source link

Feature: JupyterLab 3.0 Support Cleanup #350

Closed agoose77 closed 3 years ago

agoose77 commented 3 years ago

This PR re-runs some of my changes (from https://github.com/maartenbreddels/pythreejs/pull/2) on top of @maartenbreddels original PR (https://github.com/jupyter-widgets/pythreejs/pull/342) to ensure a cleaner Git history.

I hope that @maartenbreddels is happy for this PR to replace #342

The main changes are updating the version numbers, and moving the build directory to the pythreejs/labextension to shorten the paths and follow the cookie-cutter design.

Apologies for all the noise lately, in future I'll keep the PRs smaller in scope.

The following comment might still apply: https://github.com/jupyter-widgets/pythreejs/pull/342#discussion_r573224711

vidartf commented 3 years ago

Merged, will iterate as needed

agoose77 commented 3 years ago

Thanks a bunch @vidartf et al., I appreciate the help!