search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

Add TrackballControl. #36

Closed yungyuc closed 8 years ago

yungyuc commented 8 years ago

This PR tries to address issue #32. I use the TrackballControls.js file taken from THREE.js r70 (hash 74e7d09c262d28b3a1961ddb12ad09e6317ad8ad), which is the version shipped with pythreejs.

jasongrout commented 8 years ago

Thanks so much! I added a few comments inline.

yungyuc commented 8 years ago

Thank you so much for this wonderful project. Comments are responded inline too.

jasongrout commented 8 years ago

One more thing to make TrackballControls appear when doing from pythreejs import *, and I think this is ready to merge. Thanks again!

jasongrout commented 8 years ago

Great; thanks again!

jasongrout commented 8 years ago

All right, it should be in pythreejs 0.1.19, which I just released. Can you see if it works when installed from pypi?

yungyuc commented 8 years ago

Yes pip works. Thanks for the release!