search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
934 stars 185 forks source link

fix: deprecated use of traitlets #368

Closed maartenbreddels closed 1 year ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #368 (a5d9511) into master (150ff1c) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   70.86%   70.86%           
=======================================
  Files          23       23           
  Lines         834      834           
=======================================
  Hits          591      591           
  Misses        243      243
Impacted Files Coverage Δ
pythreejs/traits.py 90.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 150ff1c...a5d9511. Read the comment docs.

vidartf commented 2 years ago

The way I read this, it will also mean a drop of support for traitlets 4?

maartenbreddels commented 2 years ago

Hmm, i didn't think about that actually.