search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
943 stars 188 forks source link

Add resize to Renderable.js #374

Closed akaszynski closed 1 year ago

akaszynski commented 2 years ago

Automatically resizes the pythreejs Renderer.

Resolves #362.

codecov-commenter commented 2 years ago

Codecov Report

Merging #374 (671f610) into master (a78cb57) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   70.86%   70.96%   +0.10%     
==========================================
  Files          23       23              
  Lines         834      837       +3     
==========================================
+ Hits          591      594       +3     
  Misses        243      243
Impacted Files Coverage Δ
pythreejs/_base/renderable.py 85.96% <100.00%> (+0.25%) :arrow_up:
pythreejs/core/Renderer.py 82.97% <100.00%> (+0.37%) :arrow_up:
pythreejs/renderers/WebGLRenderer.py 100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

akaszynski commented 2 years ago

Hi @vidartf,

This is ready for review.

This repo has been a bit light as of late in regards to commits and PR merges. I'm at a point that I'd like to take up maintenance of this repo if possible.