Ipywidgets5 compat - Githubissues

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge

https://pythreejs.readthedocs.io

Other

951 stars 188 forks source link

Closed SylvainCorlay closed 8 years ago

SylvainCorlay commented 8 years ago

This PR contains the required changes to make pythreejs compatible with the current (backward incompatible) development version of ipywidgets.

Add a custom js side model for each pythreejs widget, providing default values on the js side for each widget attribute.
Remove the Color trait type defined in pythreejs, and now use the one defined in ipywidgets.
Use the new traitlets API.

SylvainCorlay commented 8 years ago

cc @jasongrout @jdfreder.

We should define if we make a separate branch in pythreejs for the new ipywidgets.

jasongrout commented 8 years ago

I think we should just keep it on master and release a major version when ipywidgets comes out.

jasongrout commented 8 years ago

SylvainCorlay commented 8 years ago

Misspelling at https://github.com/SylvainCorlay/pythreejs/blob/ipywidgets5_compat/pythreejs/nbextension/pythreejs.js#L1856

fixed.

jasongrout commented 8 years ago

Thanks! We won't release right away, but wait for an ipywidgets release.