jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
934 stars 185 forks source link

Fixes for 2.4.0 #386

Closed vidartf closed 1 year ago

vidartf commented 1 year ago

Some small adjust for deps, and a fix for previews on ipywidgets 7.

Fixes #385 .

codecov-commenter commented 1 year ago

Codecov Report

Merging #386 (18da0b2) into master (00626ce) will decrease coverage by 0.62%. The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   71.02%   70.39%   -0.63%     
==========================================
  Files          23       23              
  Lines         887      902      +15     
==========================================
+ Hits          630      635       +5     
- Misses        257      267      +10     
Impacted Files Coverage Δ
pythreejs/_base/Three.py 70.45% <60.00%> (-19.21%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nvaytet commented 1 year ago

Hi, is it possible to get version 2.4.1 on conda-forge? I guess this is the PR that needs to be merged? https://github.com/conda-forge/pythreejs-feedstock/pull/38 Thanks!