jupyter-widgets / pythreejs

A Jupyter - Three.js bridge

https://pythreejs.readthedocs.io

Other

943 stars 188 forks source link

Fix lumino message handling (context menu) #397

Closed vidartf closed 1 year ago

vidartf commented 1 year ago

Without this compatibility shim (https://ipywidgets.readthedocs.io/en/stable/migration_guides.html#phosphor-lumino), we no longer handle contextmenu events correctly (with ipywidgets 8).

Fixes #392.

codecov-commenter commented 1 year ago

Codecov Report

Merging #397 (99f9a9a) into master (7dacddf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   70.54%   70.54%           
=======================================
  Files          23       23           
  Lines         893      893           
=======================================
  Hits          630      630           
  Misses        263      263

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more