jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

Support THREE.BufferGeometry and BufferAttribute #46

Closed abelnation closed 7 years ago

abelnation commented 8 years ago

When dealing with large and complex geometries, it can be much more efficient to instantiate simple BufferGeometries instead of dealing with three.js's higher level Geometry class.

martinal commented 7 years ago

Are someone working on this?

martinal commented 7 years ago

In not, I'm interested in contributing, although some pointers to where to start would be most appreciated!

abelnation commented 7 years ago

Support for BufferGeometries is initially supported in this PR, which is a significant re-work of the pythreejs lib: https://github.com/jovyan/pythreejs/pull/57

martinal commented 7 years ago

Nice! Has it been decided to go with that reworked version? I can test it and report back later.

abelnation commented 7 years ago

Will let @jasongrout @SylvainCorlay comment

vidartf commented 7 years ago

This is now in via #88.