Renaming of THREE Geometry classes is confusing

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge

https://pythreejs.readthedocs.io

Other

951 stars 188 forks source link

Renaming of THREE Geometry classes is confusing #47

Closed abelnation closed 6 years ago

abelnation commented 8 years ago

Geometry -> PlainGeometry PlaneGeometry -> SurfaceGeometry ??? -> FaceGeometry

Are these discrepancies necessary? Perhaps in the python side, Geometry base class could be renamed BaseGeometry?

jasongrout commented 8 years ago

That makes sense to more closely mirror the names in three.js. The Plane->Surface transition was to emphasize to a python user that they could adjust the z-heights of each point (it wasn't just a plane).

vidartf commented 7 years ago

I think this should be incorporated before making any releases with the autogen branch (since that will be a major breaking update anyway). Especially the PlaneGeometry vs PlainGeometry is very confusing.