jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

create _package.py for storing package name info #51

Closed abelnation closed 8 years ago

abelnation commented 8 years ago

This is the start of some clean-up/organization I'd like to do within the codebase. I think the project could benefit greatly by mirroring the hierarchy of the three.js code base.

Anyways, this is just a tiny little PR to gauge whether you're welcoming to contribution or not. My plan is to split the python libraries out into separate files corresponding to the different sections of the three.js docs:

etc. ...

The result would be that __init__.py imports vars from a number of files as opposed to a single python file.

I'm curious what you think, and if you're open to me working on some clean-up/organization. Thanks!

jasongrout commented 8 years ago

We're definitely open to some help refactoring and cleaning up the code! Thanks! I'll try to take a look at this tomorrow (feel free to ping if that doesn't happen, though!)

abelnation commented 8 years ago

@jasongrout what is the best way to discuss ideas/plans with folks? I have a lot of thoughts on this repo (and was even considering writing my own from scratch, but have decided against that after careful consideration). I'd like to 1) help in whatever way i can and 2) avoid wasting time implementing ideas the maintainers do not support :)

jasongrout commented 8 years ago

Perhaps a conference video-chat with @SylvainCorlay and myself would be the best way forward.

jasongrout commented 8 years ago

What times (UTC) are good for you?

SylvainCorlay commented 8 years ago

Thanks for the contribution. We are totally open to contributions to pythreejs.

abelnation commented 8 years ago

I'm up for a video chat. I'm PST, and free most of the day. So, that'd be: 4PM - 6PM (UTC) 10PM - Midnight (UTC)

jasongrout commented 8 years ago

@abelnation - I realize it's not in the times you suggested, but @sylvainCorlay and I could talk now, or we could find a time on Monday.

abelnation commented 8 years ago

@jasongrout I could chat right now for a little bit. hangouts?

jasongrout commented 8 years ago

bluejeans.com/jupyter

jasongrout commented 8 years ago

Looks great; thanks!