search

jupyter-widgets / pythreejs

A Jupyter - Three.js bridge
https://pythreejs.readthedocs.io
Other
951 stars 188 forks source link

Autogen cleanup #94

Closed vidartf closed 7 years ago

vidartf commented 7 years ago

Merges in master naively (via #83), and tries to fix some outstanding issues in the autogen branch.

honorabel commented 7 years ago

At some point, we should start documenting our "custom" classes that we are exposing, e.g. TextTexture and ImageTexture and why they are each necessary.

vidartf commented 7 years ago

I've continued working on this, and I think maybe this PR can simply be merged and iterated on, then I can send further fixes as more specific PRs.

vidartf commented 7 years ago

However, note that this contains #83, should I remove those commits first?

honorabel commented 7 years ago

I don't see any real issue with merging.